[Core][CoreWorker] fix data race during exiting #18902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
commented
Sep 26, 2021
| }, | ||
| // We need to kill it regardless if the RPC failed. | ||
| [this]() { Exit(rpc::WorkerExitType::INTENDED_EXIT); }); | ||
| send_reply_callback( |
scv119
force-pushed
the
core-worker-fix1
branch
from
49f3dbf
to
a670cef
Compare
2 tasks
mwtian
approved these changes
Sep 26, 2021
src/ray/core_worker/core_worker.h
Outdated
| @@ -1409,7 +1409,8 @@ class CoreWorker : public rpc::CoreWorkerServiceHandler { | |||
| ObjectID object_id, void *py_future); | |||
|
|
|||
| /// Whether we are shutting down and not running further tasks. | |||
| bool exiting_ = false; | |||
| /// Being accessed by grpc thread and task_execution_service_ thread. | |||
| std::atomic<bool> exiting_; | |||
There was a problem hiding this comment.
Good to comment on the behavior.
Btw, why not keep setting its default value?
Does it matter to call exiting_.load(std::memory_order_relaxed) when it is read?
scv119
force-pushed
the
core-worker-fix1
branch
from
a670cef
to
e8242f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exiting_ is being accessed by multiple threads; it should be atomic to be thread safe.