Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Gym to 0.19 #19170

Merged
merged 1 commit into from Oct 7, 2021
Merged

Pin Gym to 0.19 #19170

merged 1 commit into from Oct 7, 2021

Conversation

avnishn
Copy link
Contributor

@avnishn avnishn commented Oct 6, 2021

Gym appears to have cut a release, 0.21.
It isn't clear what changes were made
between 0.19/0.20 and 0.21, as there is
no change log available for the 0.21 release,
so for now we'll pin gym to 0.19 until we
can fully understand the breaking changes
in gym 0.21. I suspect some things have
just been removed from the regular gym installation
that rllib has previously relied on. Will address
later.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@avnishn avnishn requested a review from simon-mo October 6, 2021 23:28
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check the rllib test passing.

@gjoliver
Copy link
Member

gjoliver commented Oct 7, 2021

learning test is still failing with the same erorr message.

I wonder if the real issue is that we are only installing gym[atari] here
https://github.com/ray-project/ray/blob/master/python/requirements/ml/requirements_rllib.txt#L7

maybe with this release, gym[atari] will not install the basic gym envs anymore.
so try adding gym in requirements_rllib.txt?

Gym appears to have cut a release, 0.21.
It isn't clear what changes were made
between 0.19/0.20 and 0.21, as there is
no change log available for the 0.21 release,
so for now we'll pin gym to 0.19 until we
can fully understand the breaking changes
in gym 0.21. I suspect some things have
just been removed from the regular gym installation
that rllib has previously relied on. Will address
later.
@sven1977 sven1977 merged commit bbc64a7 into ray-project:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants