[Datasets] Add support for slicing Arrow blocks that contain tensor columns. #19494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
reviewed
Oct 18, 2021
ericl
approved these changes
Oct 18, 2021
ericl
added
the
@author-action-required
…at Arrow schema is preserved.
clarkzinzow
removed
the
@author-action-required
scv119
approved these changes
Oct 19, 2021
|
It seems as if the failing RayDP test is unrelated? It looks like the Java gateway is failing to launch: https://buildkite.com/ray-project/ray-builders-pr/builds/16131#5696868f-e647-48a8-a9d5-61bf0379b387 |
|
Yep it should be unrelated: #19471 |
clarkzinzow
added
the
tests-ok
clarkzinzow
added a commit
to clarkzinzow/ray
that referenced
this pull request
Oct 20, 2021
…contain tensor columns. (ray-project#19494)" (ray-project#19517)" This reverts commit a6f9c93.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for slicing
ArrrowBlocks that contain tensor columns.Our current method of copying a table during block slicing breaks tensor column support, since
ChunkedArray.to_pandas()doesn't respect our extension array, giving a Pandas Series with an opaquenp.object_dtype, which causes later table construction to fail.This PR fixes this by doing a Pandas DataFrame roundtrip,
pyarrow.Table.from_pandas(view.to_pandas()), to copy the table, which preserves the extension type metadata.Related Issue
Closes #19476
Checks
scripts/format.shto lint the changes in this PR.