Revert "[Datasets] Add support for slicing Arrow blocks that contain tensor columns." #19517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
approved these changes
Oct 19, 2021
|
For some additional context, it appears that this is causing a change in the performance which leads the GPU tests to time out (not error out). Before: https://buildkite.com/ray-project/ray-builders-branch/builds/4048#4dd2af8e-9267-45bb-84cf-5e5abd041c4c
|
|
I see. then, it is likely this is since the patch was incorrect, and not actually causing a copy of the data (that might have been why I didn't go with .to/from pandas in the first place @clarkzinzow ). |
ericl
deleted the
revert-19494-datasets/fix/tensor-column-block-slice-copy
branch
clarkzinzow
added a commit
to clarkzinzow/ray
that referenced
this pull request
Oct 20, 2021
…contain tensor columns. (ray-project#19494)" (ray-project#19517)" This reverts commit a6f9c93.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19494
tune_linear_dataset_example is not happy.