-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tune] Add random state to BasicVariantGenerator
#20926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, just some minor comments
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
…into basic_variant_set_seed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits
Why are these changes needed?
This PR adds an ability to set a random seed/numpy random generator in
BasicVariantGenerator
, allowing for reproducibility across separate runs. All the changes are fully backwards compatible.Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.