[tune] Elongate test_trial_scheduler_pbt timeout. #21120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwjiang2010
force-pushed
the
fix_pbt_test
branch
from
2c8e7da
to
a2db426
Compare
|
If this timeout extension is concerning, it could be worth opening up a lower-priority issue for investigating why the test suite is taking a good bit longer, especially the discrepancy between CI and running locally! |
clarkzinzow
approved these changes
Dec 16, 2021
xwjiang2010
added a commit
that referenced
this pull request
Dec 17, 2021
This reverts commit a85df8c.
simon-mo
pushed a commit
that referenced
this pull request
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Pretty sure that the test suite is timing out at 900s now. Although locally it's only taking 600s.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.