[runtime env] Make env_vars take effect when pip install packages #22730
Conversation
Catch-Bull
requested review from
architkulkarni,
fyrestone,
SongGuyang and
edoakes
| await check_output_cmd(pip_install_cmd, logger=logger, cwd=cwd, env={}) | ||
| pip_env = os.environ.copy() | ||
| pip_env.update(env_vars) | ||
| await check_output_cmd(pip_install_cmd, logger=logger, cwd=cwd, env=pip_env) |
There was a problem hiding this comment.
In the common case, env_vars is empty, so here we would be changing env={} to env=os.environ.copy(). These two should behave exactly the same with check_output_cmd, right? Just want to double check.
There was a problem hiding this comment.
the argument env means overwrite not update, for example, you can run this command:
python test_subprocess.pytest_subprocess.py:
import subprocess
print(subprocess.check_output(["env"], env={}).decode("utf-8"))It will print nothing, env=None and env=os.environ.copy() has same behave, you can verify it by the above command.
maybe I should open a new PR to make |
| f.writelines(python_code) | ||
|
|
||
| gz_filename = os.path.join(tmpdir, package_name + ".tar.gz") | ||
| subprocess.check_call(["tar", "-zcvf", gz_filename, package_name]) |
|
|
architkulkarni
added
the
tests-ok
…y-project#22730) Previously, for the stability of pip installation, we set env to empty, but when pip installs some gzip package, maybe need env_vars. like this issue: ray-project#22610
Why are these changes needed?
Previously, for the stability of pip installation, we set env to empty, but when pip installs some gzip package, maybe need env_vars. like this issue: #22610
Related issue number
Checks
scripts/format.shto lint the changes in this PR.