Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KubeRay] Pin autoscaler image #22987

Conversation

DmitriGekhtman
Copy link
Contributor

Why are these changes needed?

Sets the autoscaler image to the one from this PR's commit.
#22847

When Ray 1.12.0 is released, we will start using released versions of Ray for the autoscaler image.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@DmitriGekhtman
Copy link
Contributor Author

cc @Jeffwan , I'm going to follow up with the same change in the KubeRay repo.

@DmitriGekhtman
Copy link
Contributor Author

DmitriGekhtman commented Mar 10, 2022

cc @Jeffwan , I'm going to follow up with the same change in the KubeRay repo.

Actually, never mind!
I see the KubeRay repo has an independent image kuberay/autoscaler:nightly.
It's fine to manage that image independently.

We can discuss some more.

@DmitriGekhtman DmitriGekhtman merged commit 19b4281 into ray-project:master Mar 10, 2022
@Jeffwan
Copy link
Contributor

Jeffwan commented Mar 10, 2022

Sounds good. For short term, we can use kuberay/autoscaler:nightly before v1.12.0 release. That might be easier

@DmitriGekhtman DmitriGekhtman deleted the dmitri/pin-kuberay-autoscaler-image branch March 10, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants