[RLlib] Fix AlphaStar for tf2+tracing; smaller cleanups around avoiding to wrap a TFPolicy as_eager() or with_tracing more than once.
#24271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
gjoliver,
avnishn,
ArturNiederfahrenhorst and
smorad
as code owners
avnishn
approved these changes
Apr 27, 2022
gjoliver
approved these changes
Apr 27, 2022
gjoliver
reviewed
Apr 27, 2022
rllib/utils/tf_utils.py
Outdated
| if hasattr(orig_cls, "as_eager"): | ||
| # Create eager-class (if not already one). | ||
| if hasattr(orig_cls, "as_eager") and \ | ||
| not issubclass(orig_cls, EagerTFPolicy): | ||
| cls = orig_cls.as_eager() | ||
| if config.get("eager_tracing"): |
There was a problem hiding this comment.
per our offline message, I think the real fix should actually be to pull this
if config.get("eager_tracing"): cls = cls.with_tracing()
block out of as_eager block.
so we will try to enable tracing regardless if we as_eager() here, or somewhere else.
just FYI.
There was a problem hiding this comment.
You are right. Thanks for the catch.
…k_not_to_double_wrap_eager
sven1977
changed the title
as_eager() 2x.as_eager() or with_tracing more than once.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AlphaStar for tf2+tracing; smaller cleanups around avoiding to wrap a TFPolicy
as_eager()orwith_tracingmore than once.Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.