Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asking Bazel to announce config it finds in bazelrcs to make CI comprehension easier #28792

Merged
merged 2 commits into from Sep 27, 2022

Conversation

cadedaniel
Copy link
Member

@cadedaniel cadedaniel commented Sep 26, 2022

I had to debug a windows failure last week and it was a major pain. I managed to create the BK environment to iterate faster. This flag helped me understand what Bazel does in CI. See this slack thread for more context.

Example output on windows:

(22:29:21) INFO: Reading 'startup' options from c:\users\containeradministrator\.bazelrc: --output_user_root=C:/tmp, --output_user_root=c:/tmp
(22:29:21) INFO: Options provided by the client:
  Inherited 'common' options: --isatty=0 --terminal_columns=80
(22:29:21) INFO: Options provided by the client:
  'build' options: --python_path=C:/Miniconda3/python.exe
(22:29:21) INFO: Reading rc options for 'build' from c:\install\ray\.bazelrc:
  'build' options: --enable_platform_specific_config --compilation_mode=opt --per_file_copt=\.pb\.cc$@-w --per_file_copt=-\.(asm|S)$,external/.*@-w --per_file_copt=-\.(asm|S)$,external/com_github_grpc_grpc/.*@-DGRPC_BAZEL_BUILD --http_time
out_scaling=5.0 --verbose_failures --strict_java_deps=off
(22:29:21) INFO: Reading rc options for 'build' from c:\users\containeradministrator\.bazelrc:
  'build' options: --config=ci --announce_rc --config=ci --remote_upload_local_results=false
(22:29:21) INFO: Found applicable config definition build:ci in file c:\install\ray\.bazelrc: --color=yes --curses=no --keep_going --progress_report_interval=100 --show_progress_rate_limit=15 --show_task_finish --ui_actions_shown=1024 --sh
ow_timestamps
(22:29:21) INFO: Found applicable config definition build:ci in file c:\install\ray\.bazelrc: --color=yes --curses=no --keep_going --progress_report_interval=100 --show_progress_rate_limit=15 --show_task_finish --ui_actions_shown=1024 --sh
ow_timestamps
(22:29:21) INFO: Found applicable config definition build:windows in file c:\install\ray\.bazelrc: --action_env=PATH --cxxopt=/std:c++17 --enable_runfiles --attempt_to_print_relative_paths --experimental_repository_cache_hardlinks --incomp
atible_strict_action_env --color=yes
(22:29:22) INFO: Current date is 2022-09-26
(22:29:22) Loading:
(22:29:22) Loading: 0 packages loaded

…ehension easier

Signed-off-by: Cade Daniel <cade@anyscale.com>
@simon-mo
Copy link
Contributor

upon second thought, can we only enable this in CI environment? devs also run this script locally, which can be spammy (?). You can check the existence of env var CI

Signed-off-by: Cade Daniel <cade@anyscale.com>
@cadedaniel
Copy link
Member Author

The failures all appear unrelated to this change. @simon-mo can you merge this?

@simon-mo simon-mo merged commit a28ab0c into ray-project:master Sep 27, 2022
@cadedaniel cadedaniel deleted the announce-bazelrc branch September 27, 2022 21:20
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…make CI comprehension easier (ray-project#28792)

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants