-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiler] Use Exec to avoid templating issues. #39019
Merged
ijrsvt
merged 3 commits into
ray-project:master
from
ijrsvt:avoid-subprocess-shell-for-profiling
Sep 5, 2023
Merged
[Profiler] Use Exec to avoid templating issues. #39019
ijrsvt
merged 3 commits into
ray-project:master
from
ijrsvt:avoid-subprocess-shell-for-profiling
Sep 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
thomasdesr
reviewed
Aug 28, 2023
Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
rkooo567
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol good catch..
|
Failing tests are not related to the PR. Tested that profiling still works locally. |
LeonLuttenberger
pushed a commit
to jaidisido/ray
that referenced
this pull request
Sep 5, 2023
Cleans up profiler to always use the actual `py-spy` path. This PR also uses a list of arguments to pass to subprocess, instead of a string. Finally, this PR ensures that format is one of the expected types.
ijrsvt
added a commit
to ijrsvt/ray
that referenced
this pull request
Sep 5, 2023
Cleans up profiler to always use the actual `py-spy` path. This PR also uses a list of arguments to pass to subprocess, instead of a string. Finally, this PR ensures that format is one of the expected types. Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
8 tasks
GeneDer
pushed a commit
that referenced
this pull request
Sep 5, 2023
Cleans up profiler to always use the actual `py-spy` path. This PR also uses a list of arguments to pass to subprocess, instead of a string. Finally, this PR ensures that format is one of the expected types. Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Sep 8, 2023
Cleans up profiler to always use the actual `py-spy` path. This PR also uses a list of arguments to pass to subprocess, instead of a string. Finally, this PR ensures that format is one of the expected types.
jimthompson5802
pushed a commit
to jimthompson5802/ray
that referenced
this pull request
Sep 12, 2023
Cleans up profiler to always use the actual `py-spy` path. This PR also uses a list of arguments to pass to subprocess, instead of a string. Finally, this PR ensures that format is one of the expected types. Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Cleans up profiler to always use the actual `py-spy` path. This PR also uses a list of arguments to pass to subprocess, instead of a string. Finally, this PR ensures that format is one of the expected types. Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.