Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Add scikit-optimize to Tune #3924

Merged
merged 24 commits into from
Feb 12, 2019
Merged

[tune] Add scikit-optimize to Tune #3924

merged 24 commits into from
Feb 12, 2019

Conversation

adizim
Copy link
Contributor

@adizim adizim commented Feb 1, 2019

What do these changes do?

Adds skopt async optimization loop to Tune

@richardliaw richardliaw changed the title Add skopt support to Tune [tune] Add skopt support to Tune Feb 1, 2019
@richardliaw richardliaw changed the title [tune] Add skopt support to Tune [tune] Add scikit-optimize to Tune Feb 1, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11389/
Test PASSed.

richardliaw
richardliaw reviewed Feb 1, 2019
View reviewed changes
python/ray/tune/examples/skopt_example.py Outdated Show resolved Hide resolved
python/ray/tune/suggest/skopt.py Show resolved Hide resolved
python/ray/tune/suggest/skopt.py Outdated
self._skopt_opt.tell(skopt_trial_info, -result[self._reward_attr])

def _num_live_trials(self):
return len(self._live_trial_mapping)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return len(self._live_trial_mapping)
return len(self._live_trial_mapping)

python/ray/tune/suggest/skopt.py Show resolved Hide resolved
richardliaw and others added 5 commits February 1, 2019 15:16
@richardliaw
Update python/ray/tune/examples/skopt_example.py
3c88e0f 
Co-Authored-By: adizim <adizim@berkeley.edu>
@richardliaw
Update python/ray/tune/suggest/skopt.py
19a7d97 
Co-Authored-By: adizim <adizim@berkeley.edu>
@richardliaw
Update python/ray/tune/suggest/skopt.py
8802baa 
Co-Authored-By: adizim <adizim@berkeley.edu>
review suggestions
52a6121
review suggestions
e085861
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11416/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11417/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11418/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11541/
Test PASSed.

@adizim
Copy link
Contributor Author

adizim commented Feb 5, 2019

https://github.com/ray-project/ray/pull/3844/files

@adizim
Copy link
Contributor Author

adizim commented Feb 5, 2019

image

example results

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11585/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11583/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11584/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11604/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11665/
Test FAILed.

@richardliaw richardliaw self-assigned this Feb 8, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11712/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11713/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11727/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11731/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11741/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11745/
Test FAILed.

@richardliaw

This comment has been minimized.

Sign in to view
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11755/
Test FAILed.

@richardliaw
Copy link
Contributor

jenkins retest this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11784/
Test PASSed.

@richardliaw richardliaw merged commit 9797028 into ray-project:master Feb 12, 2019
@adizim adizim deleted the tune_skopt branch February 12, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adizim @AmplabJenkins @richardliaw