Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard/Client] Update docs to Reflect Best Practices #39403

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Sep 7, 2023

Why are these changes needed?

  • Make it more clear that these are sensitive services.
  • Remove bad advice to open Ray Client to 0.0.0.0/0.

Dashboard: https://anyscale-ray--39403.com.readthedocs.build/en/39403/cluster/configure-manage-dashboard.html
Client: https://anyscale-ray--39403.com.readthedocs.build/en/39403/cluster/running-applications/job-submission/ray-client.html

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
@ijrsvt
Copy link
Contributor Author

ijrsvt commented Sep 7, 2023

Merging because doc-related tests have all passed

@ijrsvt ijrsvt merged commit c2d6f54 into ray-project:master Sep 7, 2023
14 of 15 checks passed
@ijrsvt ijrsvt deleted the ray-dashboard-best-practices branch September 7, 2023 23:44
ijrsvt added a commit to ijrsvt/ray that referenced this pull request Sep 7, 2023
…#39403)

Makes it more clear that these are sensitive services. Removes bad advice about configuring access to Ray Client.
Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
harborn pushed a commit to harborn/ray that referenced this pull request Sep 8, 2023
…#39403)

Makes it more clear that these are sensitive services. Removes bad advice about configuring access to Ray Client.
GeneDer pushed a commit that referenced this pull request Sep 8, 2023
…9422)

Makes it more clear that these are sensitive services. Removes bad advice about configuring access to Ray Client.
Signed-off-by: Ian Rodney <ian.rodney@gmail.com>
jimthompson5802 pushed a commit to jimthompson5802/ray that referenced this pull request Sep 12, 2023
…#39403)

Makes it more clear that these are sensitive services. Removes bad advice about configuring access to Ray Client.

Signed-off-by: Jim Thompson <jimthompson5802@gmail.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…#39403)

Makes it more clear that these are sensitive services. Removes bad advice about configuring access to Ray Client.

Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants