From 96ccc7f8502d4e9613b5e501c21c895df63e2cee Mon Sep 17 00:00:00 2001 From: Simon Zehnder Date: Mon, 11 Sep 2023 19:50:16 +0200 Subject: [PATCH 1/4] Fixed 'rollout_fragment_length' in pong-example by setting it to 'auto'. Signed-off-by: Simon Zehnder --- rllib/tuned_examples/ppo/pong-ppo.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rllib/tuned_examples/ppo/pong-ppo.yaml b/rllib/tuned_examples/ppo/pong-ppo.yaml index 3da49952e0ae4..275eaabdbe4cc 100644 --- a/rllib/tuned_examples/ppo/pong-ppo.yaml +++ b/rllib/tuned_examples/ppo/pong-ppo.yaml @@ -20,7 +20,7 @@ pong-ppo: vf_clip_param: 10.0 entropy_coeff: 0.01 train_batch_size: 5000 - rollout_fragment_length: 20 + rollout_fragment_length: auto sgd_minibatch_size: 500 num_sgd_iter: 10 num_workers: 32 From 0a9b4400f21238fb39e871beb0b998fd71ab9f5b Mon Sep 17 00:00:00 2001 From: Artur Niederfahrenhorst Date: Tue, 12 Sep 2023 13:23:15 -0700 Subject: [PATCH 2/4] Test pong learning PPO Signed-off-by: Artur Niederfahrenhorst --- rllib/BUILD | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/rllib/BUILD b/rllib/BUILD index 2aae7e6313707..35945c7bcea2c 100644 --- a/rllib/BUILD +++ b/rllib/BUILD @@ -671,6 +671,17 @@ py_test( ) # PPO + +py_test( + name = "learning_test_pong_ppo", + main = "tests/run_regression_tests.py", + tags = ["team:rllib", "exclusive", "learning_tests", "learning_tests_pong", "learning_tests_discrete"], + size = "medium", + srcs = ["tests/run_regression_tests.py"], + data = ["tuned_examples/ppo/pong-ppo.yaml.py"], + args = ["--dir=tuned_examples/ppo"] +) + py_test( name = "learning_tests_cartpole_truncated_ppo", main = "tests/run_regression_tests.py", From 1f7398c3ac1ff600ca6b4ff18ac82d674916721c Mon Sep 17 00:00:00 2001 From: Simon Zehnder Date: Wed, 13 Sep 2023 01:09:57 +0200 Subject: [PATCH 3/4] Fixed little typo in regression tests for PPO Pong. Signed-off-by: Simon Zehnder --- rllib/BUILD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rllib/BUILD b/rllib/BUILD index 35945c7bcea2c..e479632b7ff9a 100644 --- a/rllib/BUILD +++ b/rllib/BUILD @@ -678,7 +678,7 @@ py_test( tags = ["team:rllib", "exclusive", "learning_tests", "learning_tests_pong", "learning_tests_discrete"], size = "medium", srcs = ["tests/run_regression_tests.py"], - data = ["tuned_examples/ppo/pong-ppo.yaml.py"], + data = ["tuned_examples/ppo/pong-ppo.yaml"], args = ["--dir=tuned_examples/ppo"] ) From ea9ec5c3e37c4c48a366d1304000798c4719e661 Mon Sep 17 00:00:00 2001 From: Simon Zehnder Date: Wed, 13 Sep 2023 12:21:02 +0200 Subject: [PATCH 4/4] Removed pong test from BUILD, following @sven1977 's comment. Signed-off-by: Simon Zehnder --- rllib/BUILD | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/rllib/BUILD b/rllib/BUILD index f2643aa1cd89a..89151bd0881e9 100644 --- a/rllib/BUILD +++ b/rllib/BUILD @@ -671,17 +671,6 @@ py_test( ) # PPO - -py_test( - name = "learning_test_pong_ppo", - main = "tests/run_regression_tests.py", - tags = ["team:rllib", "exclusive", "learning_tests", "learning_tests_pong", "learning_tests_discrete"], - size = "medium", - srcs = ["tests/run_regression_tests.py"], - data = ["tuned_examples/ppo/pong-ppo.yaml"], - args = ["--dir=tuned_examples/ppo"] -) - py_test( name = "learning_tests_cartpole_truncated_ppo", main = "tests/run_regression_tests.py",