[Release / DO NOT MERGE] Update release tests to Python 3.14#63270
[Release / DO NOT MERGE] Update release tests to Python 3.14#63270pseudo-rnd-thoughts wants to merge 51 commits into
Conversation
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request updates the Python version for various release tests from 3.10 or 3.12 to 3.14. The reviewer identified several critical issues: Python 3.14 is not yet a released version, suggesting a widespread typo, and the change introduces incompatibilities with existing Python 3.12 lockfiles and specialized Docker images used in the testing infrastructure.
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
aslonnie
left a comment
There was a problem hiding this comment.
(skipping review on draft pr)
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
…14-release-testing
…14-release-testing
…d-thoughts/ray into py3.14-release-testing
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
Signed-off-by: Mark Towers <mark@anyscale.com>
| srcs: | ||
| - python/requirements.txt | ||
| - python/deplocks/llm/rayllm_py312_cu130.lock | ||
| - python/deplocks/llm/rayllm_py314_cu130.lock |
There was a problem hiding this comment.
LLM lock files referenced but don't exist
High Severity
The wanda configs now reference rayllm_py314_cu130.lock, rayllm_test_py314_cpu.lock, and rayllm_test_py314_cu130.lock under srcs, but only py312 versions of these files exist in python/deplocks/llm/. The ci/test_compile_llm_requirements.sh script will also fail immediately since it tries to cp the py314 lock files that don't exist. These files need to be generated and committed before the LLM Docker builds can succeed.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 2dfd281. Configure here.
Signed-off-by: Mark Towers <mark@anyscale.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
Reviewed by Cursor Bugbot for commit 25dec9e. Configure here.
| array: | ||
| python: | ||
| - "3.12" | ||
| - "3.14" |
There was a problem hiding this comment.
Ray-LLM push validation will fail for Python 3.14
Medium Severity
The ray-llm build configs are changed from Python 3.12 to 3.14, but ray-images.json still lists only ["3.12"] for ray-llm. The push_ray_image step calls RayImage.validate(), which checks the python version against PYTHON_VERSIONS_RAY_LLM loaded from ray-images.json. Since 3.14 is not in that list, validate() will raise RayImageError("Invalid python version 3.14 for ray-llm"), causing the publish steps to fail.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 25dec9e. Configure here.
| # syntax=docker/dockerfile:1.3-labs | ||
|
|
||
| ARG BASE_IMAGE | ||
| ARG FULL_BASE_IMAGE=rayproject/ray:nightly"$BASE_IMAGE" |
There was a problem hiding this comment.
Dockerfile ARG default contains literal quote characters
Low Severity
The default value for FULL_BASE_IMAGE includes literal double-quote characters around $BASE_IMAGE, producing a malformed image name like rayproject/ray:nightly"value". While this default is always overridden by the wanda build args, the fallback value is syntactically incorrect and could cause confusing failures if someone builds this Dockerfile standalone.
Reviewed by Cursor Bugbot for commit 25dec9e. Configure here.


[DO NOT MERGE]
Description
Testing all the release tests with Python 3.14
All nightly core, clusters, data, ml are passing with only a single
tunerelated bug.Next: serve test
we can't test llm as cuda-tile hasn't got 3.14 tests yet (May 22nd)