Feature/forge sites #1115
Feature/forge sites #1115
Conversation
raycastbot
added
the
extension fix / improvement
|
Thank you for your first contribution! 🎉 🔔 @KevinBatdorf you might want to have a look. |
There was a problem hiding this comment.
Hey @macbookandrew Thanks for adding these. I think they will be useful. I left a few comments. Also, maybe you're not done yet too, but there was a prettier error as well.
I have a question. Do you notice sometimes when using this extension that if you type too quickly on load that the text you type before the site's load in is carried through to the next view? I think it's a Raycast bug but not sure if it's only me experiencing it. It could also be that I need to tweak the loading mechanism too.
| @@ -81,6 +81,18 @@ export const SitesSingleView = ({ site, server }: { site: ISite; server: IServer | |||
| <> | |||
| <List searchBarPlaceholder="Search sites..."> | |||
| <List.Section title={`Site Commands (${current.name})`}> | |||
| <List.Item | |||
There was a problem hiding this comment.
Can you put this second?
There was a problem hiding this comment.
Well I should have asked if you think it's more useful at the top. Personally I mainly use the deploy exclusively, but I wonder if I'm the only one. What do you think?
There was a problem hiding this comment.
We have gitlab webhooks set up that run deploy automatically so personally I would rarely use the deploy script, but I frequently open the site in the Forge dashboard to check/modify a .env value or perform some other task
There was a problem hiding this comment.
I'm thinking the Open command may be more popular. I think that's how the Alfred workflow worked. If you want to add it back to how you had it then I think that's fine. I don't think it should be specific to my personal use.
There was a problem hiding this comment.
Done—same on the quick links too
| key="open-on-forge" | ||
| title="Open on Laravel Forge" | ||
| icon={Icon.Globe} | ||
| accessoryTitle="forge.laravel.com" |
There was a problem hiding this comment.
This should probably have the site name included, right?
There was a problem hiding this comment.
I guess it could; I made it parallel with the server but 🤷♂️
There was a problem hiding this comment.
It's fine either way. What ever you think. I just added it originally because it looked worse with nothing there at all. It's probably okay how you have it now.
| <List.Item | ||
| id="edit-site-env" | ||
| key="edit-site-env" | ||
| title="Edit .env file" | ||
| icon={Icon.Globe} | ||
| accessoryTitle="press to edit in browser" | ||
| actions={ | ||
| <ActionPanel> | ||
| <OpenInBrowserAction url={`https://forge.laravel.com/servers/${server.id}/sites/${site.id}/environment`} /> | ||
| </ActionPanel> | ||
| } | ||
| /> |
There was a problem hiding this comment.
It seems like this would fit better as a sub action to the view .env file. What do you think?
There was a problem hiding this comment.
Sure, that makes sense
Yes, but I’m seeing that with other Raycast extensions, so I suspect it’s a Raycast bug. |
|
I also just added the “open on forge” quick action for sites:
|
|
LGTM If you have any other ideas of what features might be useful I'd be interested in working on it some more. I was thinking, for example, to somehow detect WordPress then offer WP-CLI commands. Or detect Laravel and do the same with artisan. |
I like that idea! I guess we could run a site command to detect the presence of either |
|
Is this ready to review, or still in progress? 🔥 |
|
Ready to review as far as I’m concerned |
There was a problem hiding this comment.
Hi @macbookandrew 👋
Thanks for your contribution, much appreciated 🔥
Closes #991
Description
Adds two items to the Laravel Forge site commands:
Screenshot
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed in themediafolder