Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add archived indicator to projects #2748

Merged

Conversation

macbookandrew
Copy link
Contributor

Description

Add an archived status indicator:

Screen Shot 2022-08-31 at 15 41 03

Screencast

Checklist

@raycastbot raycastbot added the extension fix / improvement Label for PRs with extension's fix improvements label Aug 31, 2022
@raycastbot
Copy link
Collaborator

raycastbot commented Aug 31, 2022

Thank you for your contribution! 🎉

🔔 @tonka3000 @Loskir @immint023 @duboiss @metakirby5 you might want to have a look.

@pernielsentikaer
Copy link
Collaborator

Wouldn't it be better to move stars and archives to accessories, then you can add icons too?

@pernielsentikaer pernielsentikaer self-assigned this Sep 1, 2022
@macbookandrew
Copy link
Contributor Author

Ooh…very nice! Updated with accessories

@pernielsentikaer
Copy link
Collaborator

Can you check this out @tonka3000

@tonka3000
Copy link
Contributor

@pernielsentikaer i will check it in the evening

@Loskir
Copy link
Contributor

Loskir commented Sep 5, 2022

@macbookandrew could you send new screenshots please?

@Loskir
Copy link
Contributor

Loskir commented Sep 5, 2022

I don't quite like that archived projects are indicated with a red exclamation mark, maybe we should use secondary color instead?

@metakirby5
Copy link
Contributor

Agree with @Loskir, and I think Icon.Tray may be more fitting.

image

@tonka3000
Copy link
Contributor

I also would prefer an archived icon with e.g. yellowish color. The red one is very "heavy" and the color indicate something "bad".

CleanShot 2022-09-05 at 15 06 46@2x

@Loskir
Copy link
Contributor

Loskir commented Sep 5, 2022

Hmm, why are the stars not aligned?

@pernielsentikaer
Copy link
Collaborator

This seems like a bug in our end, I'll take a closer look 👁️

@macbookandrew
Copy link
Contributor Author

Agree with @Loskir, and I think Icon.Tray may be more fitting.

image

I’m not opposed to the tray, though gitlab itself does use an exclamation mark

67842476-CF75-417C-9AEF-6B54F5437452

@tonka3000
Copy link
Contributor

@macbookandrew Suggestion: Remove the Archived text and move it into the the tooltip of the accessory and make the Color of the icon yellow instead of red.

That way it would not look like an error flag and it mimic the behavior of gitlab in a raycast way.

@andrewminion-luminfire
Copy link

@tonka3000 thanks for the tooltip suggestion. Updated with yellow and tooltip:

Screen Shot 2022-09-07 at 12 58 38

@Loskir
Copy link
Contributor

Loskir commented Sep 7, 2022

Looks neat!

@pernielsentikaer pernielsentikaer merged commit d9bfde9 into raycast:main Sep 8, 2022
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/tonka3000/gitlab

@@ -22,11 +22,16 @@ import { ClearLocalCacheAction } from "./cache_actions";

export function ProjectListItem(props: { project: Project }): JSX.Element {
const project = props.project;
const accessories = [];
if (project.archived) {
accessories.push({ text: "Archived", icon: { source: Icon.ExclamationMark, tintColor: Color.Red } });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macbookandrew @andrewminion-luminfire Looks like it still has the text and is red, maybe forgot to push a commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏻 yes, I forgot to push the commit. #2837 includes that change. Sorry!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macbookandrew Please make another PR with the fix and link @pernielsentikaer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already did…see #2837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements status: awaiting response from dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants