-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add archived indicator to projects #2748
add archived indicator to projects #2748
Conversation
Thank you for your contribution! 🎉 🔔 @tonka3000 @Loskir @immint023 @duboiss @metakirby5 you might want to have a look. |
Wouldn't it be better to move stars and archives to accessories, then you can add icons too? |
Ooh…very nice! Updated with accessories |
Can you check this out @tonka3000 |
@pernielsentikaer i will check it in the evening |
@macbookandrew could you send new screenshots please? |
I don't quite like that archived projects are indicated with a red exclamation mark, maybe we should use secondary color instead? |
Agree with @Loskir, and I think |
Hmm, why are the stars not aligned? |
This seems like a bug in our end, I'll take a closer look 👁️ |
I’m not opposed to the tray, though gitlab itself does use an exclamation mark |
@macbookandrew Suggestion: Remove the That way it would not look like an error flag and it mimic the behavior of gitlab in a raycast way. |
@tonka3000 thanks for the tooltip suggestion. Updated with yellow and tooltip: |
Looks neat! |
Published to the Raycast Store: |
@@ -22,11 +22,16 @@ import { ClearLocalCacheAction } from "./cache_actions"; | |||
|
|||
export function ProjectListItem(props: { project: Project }): JSX.Element { | |||
const project = props.project; | |||
const accessories = []; | |||
if (project.archived) { | |||
accessories.push({ text: "Archived", icon: { source: Icon.ExclamationMark, tintColor: Color.Red } }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@macbookandrew @andrewminion-luminfire Looks like it still has the text and is red, maybe forgot to push a commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦🏻 yes, I forgot to push the commit. #2837 includes that change. Sorry!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@macbookandrew Please make another PR with the fix and link @pernielsentikaer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already did…see #2837
Description
Add an archived status indicator:
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder