Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should removing the toolbar button silence all notifications? #163

Closed
gregglind opened this issue Aug 1, 2014 · 6 comments
Closed

should removing the toolbar button silence all notifications? #163

gregglind opened this issue Aug 1, 2014 · 6 comments

Comments

@gregglind
Copy link
Collaborator

Suggested by MT at: https://bugzilla.mozilla.org/show_bug.cgi?id=1047117

"I couldn't capture a screenshot of this, but when removed from the toolbar using the customization feature, the popup still appears: in the middle of my gmail. That seems like an undesirable feature."

@gregglind
Copy link
Collaborator Author

We assumed the 'silencing' path would be through 'about:addon' > uninstall. Maybe making a list of all "I reject this" ideas, and tackling them would help here.

@gregglind gregglind added the ui label Aug 1, 2014
@gregglind gregglind modified the milestones: wouldbecool, later Aug 1, 2014
@raymak
Copy link
Owner

raymak commented Aug 2, 2014

I think at least we have to log this.
But silencing it is a good idea in my opinion.

@gregglind
Copy link
Collaborator Author

Research question:

  • can we solve this?

@gregglind
Copy link
Collaborator Author

ilana: cfx run (test mode), look at the pref (filter on 'feature')

@gregglind
Copy link
Collaborator Author

@raymak

options:

  • uninstall the first this time this happens (simple and elegant, look like an uninstall, but send extra message of "yo, button undo"
  • OR, check before any panel.show() if visible, else message as "cant show, no button"

@ilanasegall
Copy link
Collaborator

browser.uicustomization.state modifies instantly when button moved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants