Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd zip_eq adapter to IndexedParallelIterator (ZipEq struct version) #392
Conversation
This comment has been minimized.
This comment has been minimized.
On |
This comment has been minimized.
This comment has been minimized.
|
I've been attempting to diagnose CI failures on nightly, and it appears that The nightly before today works fine. |
This comment has been minimized.
This comment has been minimized.
|
It seems compiletest_rs 0.2.8 fixed that issue. I restarted your nightly CI runs, and Linux passed, but macOS is still queued... |
This comment has been minimized.
This comment has been minimized.
|
In the demo, there are dependencies on both cocoa-0.3.3 and cocoa-0.5.2, which both fail to build on current nightly. It seems that servo/cocoa-rs#166 fixed this for the current cocoa-rs (0.9.2), but I'm not sure what we can do here. |
This comment has been minimized.
This comment has been minimized.
|
Well that's awkward. I wonder what caused the change in Our dependency tree looks something like this:
Perhaps we should just skip rayon-demo for CI on macOS. We'll still have the basic rayon tests, but we don't need to get in the business of troubleshooting graphics stacks here... |
This comment has been minimized.
This comment has been minimized.
|
I think that this is better than itertools' zip_eq is lazy (only can panic if it reaches an end) and consequently gets in the way of good loop optimizations since it's putting a panic check between each iterator element. If itertools changes it might be to change |
This comment has been minimized.
This comment has been minimized.
|
Can you please rebase this to see how CI fares now? |
chrisvittal
added some commits
Jun 29, 2017
chrisvittal
force-pushed the
chrisvittal:zip_eq
branch
from
7a140e7
to
99c68a8
Sep 18, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
chrisvittal commentedJun 30, 2017
•
edited
This replaces #389, and is much the same. Re-implemented
zip_equsing aZipEqstruct that is a wrapper aroundZipto better alignzip_eqwith the adapters present inrayon,itertools, and the standard library.Closes #386, as I believe it has been decided to not implement
zip_longest.@cuviper it was unclear from your comments where you wanted additional documentation. Please advise and I will update.