Skip to content

/rayon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Repeat and RepeatN #397

Merged
merged 8 commits into from Oct 7, 2017

Conversation

Reviewers

@nikomatsakis nikomatsakis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cuviper @nikomatsakis @ChristopherDavenport
@cuviper
Copy link
Member

cuviper commented Jul 11, 2017

This adds:

  • unindexed, infinite iter::repeat(elt) -> Repeat
  • indexed, finite iter::repeatn(elt, n) -> RepeatN
  • Repeat methods take(n) and zip(iter) convert to RepeatN

This extends #337, opened separately for review since it's a fairly major change.
@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member Author

cuviper commented Jul 11, 2017

I wanted to add some symmetry such that IndexedParallelIterator::zip could also accept iterators that might be truncatable, but I couldn't work out the coherence. I wrote a new trait for this, with a blanket implementation to cover the existing I: IntoParallelIterator, I::Iter: IndexedParallelIterator, but rustc couldn't be convinced that Repeat<T> doesn't overlap that. I suppose in theory a downstream crate could implement IndexedParallelIterator for their own Repeat<Foo>?

@cuviper cuviper changed the title Repeat repeatn Add Repeat and RepeatN Jul 11, 2017

@cuviper cuviper referenced this pull request Jul 28, 2017

Open

Add an Iterator::cycle equivalent #330

@cuviper cuviper force-pushed the cuviper:repeat-repeatn branch from 366f6b7 to 74d8aa9 Sep 17, 2017

@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member Author

cuviper commented Sep 17, 2017

Rebased.

@cuviper cuviper requested a review from nikomatsakis Sep 17, 2017

@nikomatsakis

nikomatsakis approved these changes Sep 22, 2017
View changes

@nikomatsakis

nikomatsakis requested changes Sep 22, 2017
View changes

Copy link
Member

nikomatsakis left a comment

One minor nit to the documentation
src/iter/repeat.rs Outdated
/// means to shorten it, or consider using
/// [the `repeatn()` function](fn.repeatn.html) instead.
///
/// Example:

This comment has been minimized.

Sign in to view
Copy link
@nikomatsakis

nikomatsakis Sep 22, 2017

Member

I think that people write # Examples or something conventionally?
src/iter/repeat.rs Outdated
/// Creates a parallel iterator that produces `n` repeats of `elt`
/// (by cloning it).
///
/// Example:

This comment has been minimized.

Sign in to view
Copy link
@nikomatsakis

nikomatsakis Sep 22, 2017

Member

Same here.

@nikomatsakis nikomatsakis referenced this pull request Sep 22, 2017

Closed

Add Repeat #337

@cuviper cuviper force-pushed the cuviper:repeat-repeatn branch from 74d8aa9 to 8a92d6d Sep 23, 2017

@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member Author

cuviper commented Sep 23, 2017

Updated.
@nikomatsakis

nikomatsakis approved these changes Oct 6, 2017
View changes

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Member

nikomatsakis commented Oct 6, 2017

Needs rebase. =)

@cuviper cuviper force-pushed the cuviper:repeat-repeatn branch 2 times, most recently from 914088b to dc9197f Oct 6, 2017

ChristopherDavenport and others added some commits May 13, 2017

@ChristopherDavenport @cuviper
Add Repeat 
Creates a Parallel Iterator that endlessly repeats a single element
4979d6c
@ChristopherDavenport @cuviper
Fix Unnecessary Imports In Repeat
48c8ddb
@ChristopherDavenport @cuviper
Apply Rustfmt to repeat.rs
9435835
@ChristopherDavenport @cuviper
Remove Repeat boxing, and make test use explicit 
Needs something for using the take method which is missing, although elt should be available for any element
5e7fbba
@nikomatsakis @cuviper
address nits, add some docs
e39b171
@cuviper
Convert indexed-repeat to repeatn
e00d90c
@cuviper
Derive `Debug` for `Repeat` and `RepeatN`
19fe61a
@cuviper
Use a markdown header for repeat examples
Loading status checks…
1773693

@cuviper cuviper force-pushed the cuviper:repeat-repeatn branch from dc9197f to 1773693 Oct 7, 2017

@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member Author

cuviper commented Oct 7, 2017

bors r=nikomatsakis

bors bot added a commit that referenced this pull request Oct 7, 2017

@bors
Merge #397 
397: Add Repeat and RepeatN r=nikomatsakis a=cuviper

This adds:
- unindexed, infinite `iter::repeat(elt) -> Repeat`
- indexed, finite `iter::repeatn(elt, n) -> RepeatN`
- `Repeat` methods `take(n)` and `zip(iter)` convert to `RepeatN`

This extends #337, opened separately for review since it's a fairly major change.
Loading status checks…
c743bc0
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors bot commented Oct 7, 2017

Build succeeded

@bors bors bot merged commit 1773693 into rayon-rs:master Oct 7, 2017
2 checks passed

2 checks passed

bors Build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@narfanar narfanar referenced this pull request Oct 8, 2017

Closed

Add an std::iter::repeat() equivalent #331

@cuviper cuviper deleted the cuviper:repeat-repeatn branch Oct 12, 2017

@cuviper cuviper referenced this pull request Apr 19, 2018

Closed

Adding Rayon support to Rand #566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.