Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRaise the min version requirement because of the `?` operator #412
Conversation
This comment has been minimized.
This comment has been minimized.
|
I updated the readme to 1.13 |
dns2utf8
force-pushed the
dns2utf8:minimal_rust_version
branch
from
1f499bc
to
c8e6ece
Sep 6, 2017
dns2utf8
force-pushed the
dns2utf8:minimal_rust_version
branch
from
c8e6ece
to
63938d6
Sep 6, 2017
This comment has been minimized.
This comment has been minimized.
|
Yeah, so I should probably not have merged that PR that used (I know that @cuviper and I have differing points of view on this matter, however, as I tend to view the minimum version requirement as more of a courtesy than a hard semver requirement, so I'd like to get his take.) |
This comment has been minimized.
This comment has been minimized.
Which one was that? AFAICS the only problem here is actually in futures, where 0.1.15 uses But this highlights my real gripe, that such updated requirements are viral, and there's no tooling to deal with it. Any crate that tries to maintain compatibility is at the mercy of its dependencies to do the same. I'll be less grumpy about it when cargo learns how to ignore too-new crates, e.g. RFC 1953.
That would be rust-1.18, which is a big jump to me. And IMO |
This comment has been minimized.
This comment has been minimized.
|
You are correct. I grepped the rayon code and it contains no Imho the futures crate has about the same age as 1.12 and does not guarantee any compatibility with older compilers. Sure one could ask @alexcrichton to yank From my point of view it boils down to the questions
For my projects, I check the debian repo where the current stable release is 1.14.0 |
This comment has been minimized.
This comment has been minimized.
alexcrichton
commented
Sep 9, 2017
|
I would highly discourage dependencies like |
This comment has been minimized.
This comment has been minimized.
|
We don't really know what compiler folks may be stuck with, and that's part of the problem. The 2017 survey showed most respondents with the current version through rustup, but there were still a tail of people behind, even "1.10 or older". I wouldn't suggest that futures should yank 0.1.15. I just wish that their compatibility choice wasn't so viral. And I also agree that pinning an older version in rayon has its own problems. I suggest just stepping down the version in the CI scripts for now. |
This comment has been minimized.
This comment has been minimized.
|
#436 separated rayon-futures, so now we don't need to bump the min version for rayon. |
dns2utf8 commentedSep 6, 2017
•
edited
I fixed the tests for the latest nightly compiler in #411 but since the
?operator is in the main code the minimal required version must be raised.TODO