Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd html_root_url for core and futures, with a reminder in Cargo.toml #444
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'm not sure if this is 'okay' or not, the cargo version is 0.1.0, but the only docs up are 0.0.1 |
KodrAus
reviewed
Sep 21, 2017
KodrAus left a comment
|
Thanks @smt923! I think the version of |
rayon-futures/src/lib.rs
Outdated
| @@ -2,6 +2,8 @@ | |||
| //! | |||
| //! See `README.md` for details. | |||
|
|
|||
| #![doc(html_root_url = "https://docs.rs/rayon-futures/0")] | |||
This comment has been minimized.
This comment has been minimized.
KodrAus
Sep 21, 2017
Let's make this 0.1 so it's in line with what's in the Cargo.toml, even if that hasn't been released yet.
KodrAus
approved these changes
Sep 21, 2017
KodrAus left a comment
|
This looks good to me! |
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
cuviper
merged commit 4b2fb05
into
rayon-rs:master
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
smt923 commentedSep 21, 2017
•
edited
Should close #424 - I've used some shorter version links for the docs, but if I should just make these exactly what version is specified in the Cargo.toml I can change it, those versions just don't have any published docs yet and making a PR with links that 404'd didn't feel right (but perhaps this is totally fine)