Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html_root_url for core and futures, with a reminder in Cargo.toml #444

Merged
merged 2 commits into from Sep 21, 2017

Conversation

Projects
None yet
3 participants
@smt923
Copy link
Contributor

smt923 commented Sep 21, 2017

Should close #424 - I've used some shorter version links for the docs, but if I should just make these exactly what version is specified in the Cargo.toml I can change it, those versions just don't have any published docs yet and making a PR with links that 404'd didn't feel right (but perhaps this is totally fine)

@smt923

This comment has been minimized.

Copy link
Owner Author

smt923 commented on rayon-futures/src/lib.rs in 751ea15 Sep 21, 2017

I'm not sure if this is 'okay' or not, the cargo version is 0.1.0, but the only docs up are 0.0.1

@KodrAus
Copy link

KodrAus left a comment

Thanks @smt923!

I think the version of rayon-futures on crates.io (which is what docs.rs would build from) are just a placeholder. The 0.1.0 version here hasn't been released yet, but I think it's ok to point the html_root_url at the version that will be, so we don't forget to update it when releasing 0.1 later.

@@ -2,6 +2,8 @@
//!
//! See `README.md` for details.

#![doc(html_root_url = "https://docs.rs/rayon-futures/0")]

This comment has been minimized.

@KodrAus

KodrAus Sep 21, 2017

Let's make this 0.1 so it's in line with what's in the Cargo.toml, even if that hasn't been released yet.

@KodrAus
Copy link

KodrAus left a comment

This looks good to me!

@cuviper

This comment has been minimized.

Copy link
Member

cuviper commented Sep 21, 2017

Thanks!

@cuviper cuviper merged commit 4b2fb05 into rayon-rs:master Sep 21, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.