Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTransition from deprecated Unpark to Notify #447
Conversation
This comment has been minimized.
This comment has been minimized.
|
#357 is already working on this... Maybe you can offer a review? |
This comment has been minimized.
This comment has been minimized.
|
ah, didn't see that. |
tmccombs
closed this
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tmccombs commentedSep 25, 2017
I'm not entirely sure if this is the correct way to create a NotifyHandle from a ScopeFuture, but I do think storing the NotifyHandle in the ScopeFutureContes is the correct thing to do.