Solve inter-pool deadlocks #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Registry::in_worker()` now calls a distinct `Registry::in_worker_cross` when a `WorkerThread` *is* found for the current thread, but it's not part of this `Registry`'s pool. We use a new `TickleLatch` which will awaken a pool when it's set. Then the current thread can go process other work from its own pool, possibly going to sleep when idle, and still be notified when the other pool finishes the new work.
nikomatsakis
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registry::in_worker()now calls a distinctRegistry::in_worker_crosswhen a
WorkerThreadis found for the current thread, but it's notpart of this
Registry's pool. We use a newTickleLatchwhich willawaken a pool when it's set. Then the current thread can go process
other work from its own pool, possibly going to sleep when idle, and
still be notified when the other pool finishes the new work.