Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSolve inter-pool deadlocks #449
Conversation
cuviper
requested a review
from
nikomatsakis
Sep 25, 2017
nikomatsakis
approved these changes
Oct 6, 2017
nikomatsakis
merged commit 05c8177
into
rayon-rs:master
Oct 6, 2017
cuviper
deleted the
cuviper:interpool
branch
Oct 6, 2017
cuviper
referenced this pull request
Oct 17, 2017
Closed
Will the threadpool be shared if rayon is used in two crates included in the same project? #174
cuviper
referenced this pull request
Aug 7, 2018
Closed
Dispatching to a second pool from a job in one pool is buggy #588
cuviper
referenced this pull request
Sep 12, 2018
Open
Using rayon under a Mutex can lead to deadlocks #592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
cuviper commentedSep 25, 2017
Registry::in_worker()now calls a distinctRegistry::in_worker_crosswhen a
WorkerThreadis found for the current thread, but it's notpart of this
Registry's pool. We use a newTickleLatchwhich willawaken a pool when it's set. Then the current thread can go process
other work from its own pool, possibly going to sleep when idle, and
still be notified when the other pool finishes the new work.