Skip to content

/rayon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `rayon::split`, leaving only `rayon::iter::split` #454

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Reviewers

@nikomatsakis nikomatsakis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cuviper @nikomatsakis
@cuviper
Copy link
Member

cuviper commented Oct 8, 2017

The split function creates a ParallelIterator, which better
justifies its place in rayon::iter. It's not really used enough to
justify its place in the crate root.

Fixes #432.
@cuviper
Remove `rayon::split`, leaving only `rayon::iter::split` 
The `split` function creates a `ParallelIterator`, which better
justifies its place in `rayon::iter`.  It's not really used enough to
justify its place in the crate root.

Fixes #432.
Loading status checks…
50317a6
@nikomatsakis

nikomatsakis approved these changes Oct 10, 2017
View changes

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Member

nikomatsakis commented Oct 10, 2017

bors r+

bors bot added a commit that referenced this pull request Oct 10, 2017

@bors
Merge #354 #454 
354: Introduce `join_context` which tells whether jobs were stolen r=nikomatsakis a=cuviper

This removes the need for tracking thread-id or hacky TLS variables in
the adaptive splitter.  Instead, with `join_context` the parallel
iterator internals are directly informed whether a job is executing on
its original thread or stolen elsewhere.

Note that this is insta-stable since we want to use it ourselves.  We
could hide docs and/or mark it deprecated to approach stability a little
differently than the usual "unstable" feature.

454: Remove `rayon::split`, leaving only `rayon::iter::split` r=nikomatsakis a=cuviper

The `split` function creates a `ParallelIterator`, which better
justifies its place in `rayon::iter`.  It's not really used enough to
justify its place in the crate root.

Fixes #432.
Loading status checks…
c3ed7dc
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors bot commented Oct 11, 2017

Build succeeded

@bors bors bot merged commit 50317a6 into rayon-rs:master Oct 11, 2017
2 checks passed

2 checks passed

bors Build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cuviper cuviper deleted the cuviper:unroot-split branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.