Skip to content

/rayon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherent mutability -> Interior mutablility #458

Merged
merged 1 commit into from Oct 14, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@MajorBreakfast @cuviper
@MajorBreakfast
Copy link
Contributor

MajorBreakfast commented Oct 14, 2017

The rust book calls this "interior mutability". I think that the two terms were just confused because they sound awfully similar.

First edition: https://doc.rust-lang.org/book/first-edition/mutability.html
Second edition: https://doc.rust-lang.org/book/second-edition/ch15-05-interior-mutability.html#refcellt-and-the-interior-mutability-pattern
@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member

cuviper commented Oct 14, 2017

Ah, yep, even the std::cell docs call it "interior". Thanks!

bors r+

bors bot added a commit that referenced this pull request Oct 14, 2017

@bors
Merge #457 #458 
457: Add thorough tests for Producer::split_at r=cuviper a=cuviper

This takes one of the test cases from `intersperse`, which was very
helpful in poking corner cases, and generalizes it to test all
`Producer`s.

This found a semi-bug with `enumerate().rev()` in the process -- by
zipping with indexes up to `usize::MAX`, reverse iteration has to
iterate a loooong way back.  It now uses the exact length needed.

458: Inherent mutability -> Interior mutablility r=cuviper a=MajorBreakfast

The rust book calls this "interior mutability". I think that the two terms were just confused because they sound awfully similar.

First edition: https://doc.rust-lang.org/book/first-edition/mutability.html
Second edition: https://doc.rust-lang.org/book/second-edition/ch15-05-interior-mutability.html#refcellt-and-the-interior-mutability-pattern
Loading status checks…
75bc7a6
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors bot commented Oct 14, 2017

Build succeeded

@bors bors bot merged commit fa944d6 into rayon-rs:master Oct 14, 2017
2 checks passed

2 checks passed

bors Build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MajorBreakfast MajorBreakfast referenced this pull request Apr 13, 2018

Merged

inherent mutability -> interior mutability #564

bors bot added a commit that referenced this pull request Apr 13, 2018

@bors @MajorBreakfast
Merge #564 
564: inherent mutability -> interior mutability r=cuviper a=MajorBreakfast

It's called "interior" mutability not "inherent" mutability.

Old PR of mine that already fixed this once 😄 #458

Section in the book https://doc.rust-lang.org/book/second-edition/ch15-05-interior-mutability.html

Co-authored-by: Josef Brandl <mail@josefbrandl.de>
Loading status checks…
4474385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.