Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDocument setting the number of threads #460
Conversation
marmistrz
force-pushed the
marmistrz:numthreads
branch
2 times, most recently
from
1adb3b2
to
4f1945f
Oct 15, 2017
cuviper
reviewed
Oct 17, 2017
README.md
Outdated
|
|
||
| By default, Rayon uses the same number of threads as the number of CPUs | ||
| available. Note that on systems with hyperthreading enabled this | ||
| equals to the number of logical cores and the physical ones. |
This comment has been minimized.
This comment has been minimized.
cuviper
Oct 17, 2017
Member
Do you mean "and not the physical ones"? The way it's written sounds like perhaps you'd add these numbers, but they're overlapping values. e.g. I would say my current CPU has 4 physical cores and 8 logical cores.
This comment has been minimized.
This comment has been minimized.
marmistrz
force-pushed the
marmistrz:numthreads
branch
2 times, most recently
from
349375d
to
d129637
Oct 17, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 22, 2017
This comment has been minimized.
This comment has been minimized.
Build failed |
This comment has been minimized.
This comment has been minimized.
|
Meh, spurious appveyor failure, and this change doesn't touch code anyway. |
cuviper
merged commit cdf876d
into
rayon-rs:master
Oct 22, 2017
1 of 2 checks passed
bors
Build failed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
marmistrz commentedOct 15, 2017
No description provided.