Skip to content

/rayon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename rayon::iter::internal to rayon::iter::plumbing #463

Merged
merged 2 commits into from Nov 7, 2017

Conversation

Reviewers

@nikomatsakis nikomatsakis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lvillani @cuviper
@lvillani
Copy link
Contributor

lvillani commented Oct 19, 2017

This should fix #415.
@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member

cuviper commented Oct 22, 2017

r? @nikomatsakis - are you OK with the "plumbing" name?

We should update this header too:

These should be considered highly unstable: users of parallel iterators should not need to interact with them directly.

Let's drop the "highly unstable" part, because we're not actually making breaking changes here any differently than the rest of the API. Instead, we should clarify that these parts are only needed for implementing new parallel iterators.

@cuviper cuviper requested a review from nikomatsakis Oct 22, 2017

lvillani and others added some commits Oct 19, 2017

@lvillani @cuviper
rename rayon::iter::internal to rayon::iter::plumbing
e47c125
@cuviper
Soften the doc header on `plumbing` 
We don't really want to call this "unstable" or even "internal", because
that implies external crates should never implement parallel iterators
themselves.  Instead, the point is just that typical use shouldn't need
to worry about these "plumbing" details at all.
Loading status checks…
60c0f31
@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member

cuviper commented Nov 6, 2017

I rebased and tweaked that header.

bors r+

bors bot added a commit that referenced this pull request Nov 7, 2017

@bors
Merge #463 
463: rename rayon::iter::internal to rayon::iter::plumbing r=cuviper a=lvillani

This should fix #415.
Loading status checks…
75f95c0
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors bot commented Nov 7, 2017

Build succeeded

@bors bors bot merged commit 60c0f31 into rayon-rs:master Nov 7, 2017
2 checks passed

2 checks passed

bors Build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cuviper cuviper referenced this pull request Dec 5, 2017

Closed

cleanup public surface of parallel iterator API #228

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.