Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRelax the error locking in collecting results #470
Conversation
This comment has been minimized.
This comment has been minimized.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2017
This comment has been minimized.
This comment has been minimized.
bors
bot
merged commit 3c3d985
into
rayon-rs:master
Nov 14, 2017
2 checks passed
bors
Build succeeded
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
cuviper
deleted the
cuviper:relaxed-result-lock
branch
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
cuviper commentedNov 13, 2017
We don't need a blocking
lock(), as anybody else holding the lock willalso be writing
Some(error), and then the current error is irrelevant.