Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump coco to 0.3 #471

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Projects
None yet
3 participants
@ignatenkobrain
Copy link
Contributor

ignatenkobrain commented Nov 14, 2017

No description provided.

@cuviper

This comment has been minimized.

Copy link
Member

cuviper commented Nov 14, 2017

If stjepang/coco#20 gets merged and published, we won't have to worry about bumping rayon-core's minimum rustc for this.

@cuviper cuviper self-assigned this Nov 14, 2017

@stjepang

This comment has been minimized.

Copy link
Contributor

stjepang commented Nov 15, 2017

@cuviper Done! Merged and published.

@ignatenkobrain

This comment has been minimized.

Copy link
Contributor Author

ignatenkobrain commented Nov 15, 2017

@stjepang https://crates.io/crates/coco still doesn't list 0.3.2 ;)

bump coco to 0.3
0.3.2 is needed in order to support Rust 1.12.

Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>

@ignatenkobrain ignatenkobrain force-pushed the ignatenkobrain:patch-1 branch from 285f0d4 to d9179a4 Nov 15, 2017

@stjepang

This comment has been minimized.

Copy link
Contributor

stjepang commented Nov 15, 2017

Oops, sorry! Now it does. :)

@cuviper

This comment has been minimized.

Copy link
Member

cuviper commented Nov 16, 2017

Here are some cargo-chrono plots before and after:

rayon-pr471-points

rayon-pr471-points-medians

Mostly wins, but two big regressions:

  • fibonacci_split_recursive: this is a kind of weird one, that I'm willing to write off. FWIW, the related fibonacci_join benchmarks (not shown here) are about twice as fast now!
  • parallel_find_last: the really weird part about this is that it's now performing even worse than parallel_find_missing, which itself stayed about the same. Parallel finding the last element should be able to short-circuit and return sooner than with a missing element that has to check everything. I'm really baffled by this one!
@cuviper

This comment has been minimized.

Copy link
Member

cuviper commented Nov 16, 2017

On a whim, I just tried compiling rayon-demo with all test modules except find commented out, and now parallel_find_last does perform better than parallel_find_missing as expected, and about the same as with the old coco. But parallel_find_middle got worse.

My best guess is that these are just sensitive to changes in overall code generation and/or layout. Meh.

bors r+

bors bot added a commit that referenced this pull request Nov 16, 2017

Merge #471
471: bump coco to 0.3 r=cuviper a=ignatenkobrain
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Nov 16, 2017

@bors bors bot merged commit d9179a4 into rayon-rs:master Nov 16, 2017

2 checks passed

bors Build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.