Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note how minimum length behaves with combined iterators #475

Merged
merged 2 commits into from Nov 17, 2017

Conversation

Projects
None yet
2 participants
@kornelski
Copy link
Contributor

kornelski commented Nov 17, 2017

Closes #472

@cuviper

This comment has been minimized.

Copy link
Member

cuviper commented Nov 17, 2017

Looks good! Can you please add a similar note to with_max_len?

@kornelski

This comment has been minimized.

Copy link
Contributor Author

kornelski commented Nov 17, 2017

OK. I assume it's a logical opposite for the max function.

@cuviper

This comment has been minimized.

Copy link
Member

cuviper commented Nov 17, 2017

Yep, thanks!

bors r+

bors bot added a commit that referenced this pull request Nov 17, 2017

Merge #475
475: Note how minimum length behaves with combined iterators r=cuviper a=pornel

Closes #472
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Nov 17, 2017

@cuviper

This comment has been minimized.

Copy link
Member

cuviper commented Nov 17, 2017

Surely not your fault, but on OSX nightly with rayon_unstable:

---- src/range.rs - range (line 6) stdout ----
	thread 'rustc' panicked at 'test executable failed:

', src/librustdoc/test.rs:323:16

But the regular OSX nightly passed, and range.rs shouldn't be affected by any rayon_unstable stuff, so let's try again...

bors r+

bors bot added a commit that referenced this pull request Nov 17, 2017

Merge #475
475: Note how minimum length behaves with combined iterators r=cuviper a=pornel

Closes #472
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Nov 17, 2017

@bors bors bot merged commit e8304d7 into rayon-rs:master Nov 17, 2017

2 checks passed

bors Build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.