New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add library versioning to Make/CMake build systems #417

Merged
merged 2 commits into from Dec 11, 2017

Conversation

Projects
None yet
3 participants
@a3f
Collaborator

a3f commented Dec 10, 2017

See #401 for the discussion.
Also bumps version number to 1.9.2 without the -dev,
because neither ELF nor MachO like such a suffix for the compatibility version.
The -dev suffix will have to be restricted to the git tags.

@a3f a3f referenced this pull request Dec 10, 2017

Closed

[build] Make raylib available in package managers #401

5 of 10 tasks complete
@a3f

This comment has been minimized.

Collaborator

a3f commented Dec 10, 2017

I tested this on Linux and macOS. objdump -p libraylib.so | grep SONAME shows the ELF API version. On macOS, it's called compatibility version

@raysan5

This comment has been minimized.

Owner

raysan5 commented Dec 11, 2017

Hi @a3f! Thank you very much for the addition! Just added one comment review...

@@ -18,5 +18,5 @@ raylib = library('raylib',
source_c,
dependencies : [ glfw_dep, gl_dep, openal_dep, m_dep, x11_dep],
install : true,
version : '1.8.0')
version : '1.9.2')

This comment has been minimized.

@jubalh

jubalh Dec 11, 2017

Contributor

this is the library version.
https://github.com/raysan5/raylib/blob/master/meson.build#L1 is the version of raylib.

This comment has been minimized.

@a3f

a3f Dec 11, 2017

Collaborator

Should both be set to the same new value and if so what's the difference?

This comment has been minimized.

@a3f

a3f Dec 11, 2017

Collaborator

I removed the changes to meson.build, so you can see what changes would be appropriate.

This comment has been minimized.

@jubalh

jubalh Dec 11, 2017

Contributor

It might be best to remove meson.build and src/meson.build completely, since with this PR it doesn't provide anything more than Make/CMake does provide.

This comment has been minimized.

@a3f

a3f Dec 11, 2017

Collaborator

That would be a possibility as well. I pushed one more commit that does that.

a3f added some commits Dec 10, 2017

Add library versioning to Make/CMake build systems
See #401 for the discussion.
Also bumps version number to 1.9.2 without the -dev,
because neither ELF nor MachO like such a suffix.
The -dev suffix will have to be restricted to the git tags.
Remove Meson build system
Less maintenance overhead that way,
given that make/CMake now also do library versioning.

@raysan5 raysan5 merged commit 3e1d685 into raysan5:develop Dec 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment