Skip to content

fix: asset filter query test #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2022
Merged

fix: asset filter query test #132

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d59c22
fix: specify sql query order
scortier May 19, 2022
eb3f37c
refactor: update test
scortier May 19, 2022
1d35e1c
docs: update comment in data filter test
scortier May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions store/postgres/asset_repository_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,24 +170,24 @@ func (r *AssetRepositoryTestSuite) TestBuildFilterQuery() {
expectedQuery: `(data->'landscape'->'properties'->>'project-id' ILIKE $1 OR description ILIKE $2)`,
},
{
// NOTE: Cannot have more than one key in map because golang's map does not guarantee order thus producing
// inconsistent test.
description: "should return sql query with asset's data fields filter",
config: asset.Filter{
Data: map[string]string{
"entity": "odpf",
"country": "th",
"entity": "odpf",
},
},
expectedQuery: `data->>'entity' = 'odpf' AND data->>'country' = 'th'`,
expectedQuery: `data->>'entity' = 'odpf'`,
},
{
description: "should return sql query with asset's nested data fields filter",
config: asset.Filter{
Data: map[string]string{
"landscape.properties.project-id": "compass_001",
"country": "vn",
},
},
expectedQuery: `data->'landscape'->'properties'->>'project-id' = 'compass_001' AND data->>'country' = 'vn'`,
expectedQuery: `data->'landscape'->'properties'->>'project-id' = 'compass_001'`,
},
}

Expand Down