Skip to content

Conversation

@StewartJingga
Copy link
Contributor

Problem

lint action is being run twice whenever there is a push on pull request.

Root cause

It is because we set it to run with below config

on: [push, pull_request]

Solution

Remove pull_request as it is already included when pushing.

@StewartJingga StewartJingga added the bug Something isn't working label Feb 2, 2022
@StewartJingga StewartJingga self-assigned this Feb 2, 2022
@StewartJingga
Copy link
Contributor Author

StewartJingga commented Feb 2, 2022

@ravisuhag need help adding @scortier as odpf member 🙏 .

Cannot add him as reviewer.

@ravisuhag ravisuhag merged commit c3ada27 into main Feb 2, 2022
@ravisuhag ravisuhag deleted the fix-double-lint-action branch February 2, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants