Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.3.4 #106

Merged
merged 13 commits into from Mar 18, 2019

Conversation

Projects
None yet
2 participants
@captn3m0
Copy link
Member

captn3m0 commented Mar 8, 2019

No description provided.

captn3m0 added some commits Feb 28, 2019

[parser] Parse RTGS files as CSV instead
- Converting and parsing as CSV is much faster
Merge pull request #105 from razorpay/rtgs-csv
[parser] Parse RTGS files as CSV instead

@captn3m0 captn3m0 requested a review from patlola Mar 8, 2019

captn3m0 added some commits Mar 8, 2019

@@ -805,6 +808,7 @@
"NILX": "Nilkanth Co-operative Bank",
"NIRX": "Nirmal Urban Co-operative Bank Nagpur",
"NIUX": "Nileshwar Co-operative Urban Bank",
"NJBK": "Nav Jeevan Co-operative Bank",
"NJCX": "Nav Jeevan Co-operative Bank",

This comment has been minimized.

@patlola

patlola Mar 18, 2019

Contributor

@captn3m0 need to do a cleanup of the banknames.json once. some sublets like the above are now proper banks we have to remove all the sublet bank codes

This comment has been minimized.

@captn3m0

captn3m0 Mar 18, 2019

Author Member

I don't want to remove entries from banknames.json unless it was added in an error. Learned this the hard way after I'd removed

"VYSA": "ING Vysya Bank",

long back. But yeah, the sublet confusion is getting bigger, and the exceptions list is getting confusing. Need a better solution.

@patlola
Copy link
Contributor

patlola left a comment

looks good to me, do a data sanity check once before releasing

@captn3m0 captn3m0 self-assigned this Mar 18, 2019

@captn3m0

This comment has been minimized.

Copy link
Member Author

captn3m0 commented Mar 18, 2019

@patlola Due to some parsing error somewhere, this currently marks IFSCCODE as a valid IFSC. Don't have time to debug that, do you think we can do a release with this?

I'll ensure it doesn't reach the API.

@patlola

This comment has been minimized.

Copy link
Contributor

patlola commented Mar 18, 2019

yeah, sure. we can push this as far as the generated files are good to go. will check once on why this parsing error is happening.

@captn3m0 captn3m0 merged commit 9cc506e into master Mar 18, 2019

4 of 5 checks passed

wercker/elixir Wercker pipeline failed
Details
wercker/build Wercker pipeline passed
Details
wercker/npm-test Wercker pipeline passed
Details
wercker/php-composer-test Wercker pipeline passed
Details
wercker/rubygem-rake Wercker pipeline passed
Details

@captn3m0 captn3m0 deleted the release/1.3.4 branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.