Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd pushall fixes #1

Merged
merged 10 commits into from Mar 25, 2019

Conversation

Projects
None yet
2 participants
@venkatvghub
Copy link

venkatvghub commented Aug 27, 2018

  • kubernetes api client fixes
  • fixes aws boto region for handling non default regions in dynamodb stream client
  • dynamodb stream fix to handle shard iteration
  • fixes exception/error handling for dynamodb responses

@venkatvghub venkatvghub requested a review from captn3m0 Aug 27, 2018

kubernetes.config.load_incluster_config()
api_client = kubernetes.client.CoreV1Api()
return api_client
#api_client = kubernetes.client.ApiClient(configuration=kubernetes.client.configuration)

This comment has been minimized.

Copy link
@captn3m0

captn3m0 Sep 5, 2018

Member

remove commented code

if not response['StreamDescription']['Shards']:
print("fatal: no shards found for DynamoDB stream '{arn}'.".format(arn=arn))
sys.exit(1)
try:

This comment has been minimized.

Copy link
@captn3m0

captn3m0 Sep 5, 2018

Member

Wondering if the pod will restart properly after this. (What do we keep as a healthcheck?)

This comment has been minimized.

Copy link
@venkatvghub

venkatvghub Oct 25, 2018

Author

ps -ef|grep kubestash or something like that? Just checks if the process is running else restart

print("detected DynamoDB changes, running push command...")
argscopy = copy.copy(args)
argscopy.secretname = key
cmd_pushall(argscopy)

This comment has been minimized.

Copy link
@captn3m0

captn3m0 Sep 5, 2018

Member

Why are we still doing a pushall? I thought the idea was to run a selective patch on the secret.ENV for every change.

This comment has been minimized.

Copy link
@venkatvghub

venkatvghub Oct 26, 2018

Author

@captn3m0 need some clarity on this. Lets sync up when am back from indore

@captn3m0
Copy link
Member

captn3m0 left a comment

Force merging for now.

@captn3m0 captn3m0 merged commit 29af02f into cmd-pushall Mar 25, 2019

@captn3m0 captn3m0 deleted the cmd-pushall-fixes branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.