Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5.0+ Support (Drops Rails 4.2 Support) #192

Open
wants to merge 44 commits into
base: master
from

Conversation

@joelvh
Copy link
Contributor

commented Nov 16, 2017

  • Upgraded CASino to support Rails 5.0+
  • Fixed tests
  • Addressed deprecations
  • Added Appraisals to test multiple versions of Rails
  • Dropped Rails 4.2 support because integration tests require keyword arguments and this isn't supported by Rails 4.2
  • Additional fixes

Please submit PRs to our branch for CASino maintenance: https://github.com/identification-io/CASino

meanphil and others added some commits Aug 25, 2015

Add context argument for an authenticator to use
Sometimes a login might require more information than just a username and password, in these cases the extra info can be pased to the authenticator via the context parameter as a Hash.
Use `data_source_exists?` to check for tables and views - gets rid of…
… deprecation warning that `table_exists?` will only check tables in Rails 5.1
@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2017

Coverage Status

Coverage increased (+0.04%) to 97.236% when pulling f473af1 on identification-io:master into ff29323 on rbCAS:master.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2017

Coverage Status

Coverage increased (+0.04%) to 97.236% when pulling f473af1 on identification-io:master into ff29323 on rbCAS:master.

@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2017

Coverage Status

Coverage increased (+0.04%) to 97.236% when pulling f473af1 on identification-io:master into ff29323 on rbCAS:master.

@joelvh joelvh referenced this pull request Nov 16, 2017
@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2017

Coverage Status

Coverage decreased (-0.1%) to 97.103% when pulling c233077 on identification-io:master into ff29323 on rbCAS:master.

@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2017

Coverage Status

Coverage decreased (-0.1%) to 97.103% when pulling 2e989ae on identification-io:master into ff29323 on rbCAS:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2017

Coverage Status

Coverage decreased (-0.1%) to 97.103% when pulling 2e989ae on identification-io:master into ff29323 on rbCAS:master.

joelvh added some commits Nov 16, 2017

@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2017

Coverage Status

Coverage increased (+0.02%) to 97.226% when pulling 01cd1b4 on identification-io:master into ff29323 on rbCAS:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2017

Coverage Status

Coverage increased (+0.02%) to 97.226% when pulling 01cd1b4 on identification-io:master into ff29323 on rbCAS:master.

@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2017

Coverage Status

Coverage increased (+0.02%) to 97.226% when pulling 723dd0d on identification-io:master into ff29323 on rbCAS:master.

matrix:
allow_failures:
- rvm: 2.4.0
- rvm: 2.4.1

This comment has been minimized.

Copy link
@pencil

pencil Nov 16, 2017

Member

Why are there failures on 2.4.0 and 2.4.1? Seems slightly concerning.

This comment has been minimized.

Copy link
@joelvh

joelvh Nov 16, 2017

Author Contributor

@pencil something is causing the appraisal gem to not load properly on Travis to be able to run the tests - started looking into it, but not conclusive yet

@@ -0,0 +1,22 @@
# 11/15/2017 - v5.0.0

This comment has been minimized.

Copy link
@pencil

pencil Nov 16, 2017

Member

We maintain the change log for CASino using GitHub's release page.

@@ -0,0 +1,3 @@
class CASino::ApplicationRecord < ActiveRecord::Base

This comment has been minimized.

Copy link
@pencil

pencil Nov 16, 2017

Member

What's the advantage of using this class over ActiveRecord::Base directly?

This comment has been minimized.

Copy link
@joelvh

joelvh Nov 16, 2017

Author Contributor

@pencil Followed the Rails 5.0+ best practice. Also could serve as a better entry point for potential monkey-patching if needed.

@dixalex

This comment has been minimized.

Copy link

commented Dec 21, 2018

Hey folks. What's the status of this PR? Any luck it can be finished and merged some time soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.