Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump from prereleases not working as expected #24

Closed
MinchinWeb opened this issue Aug 31, 2015 · 4 comments

Comments

@MinchinWeb
Copy link
Contributor

commented Aug 31, 2015

I was expecting that a prerelease version, when bumped, would go up to the 'full' or release version without bumping the main version number if not needed.

Probably makes more sense if I give examples.

What I expected:

1.0.0-dev --[major]--> 1.0.0
1.0.1-dev --[major]--> 2.0.0
1.1.0-dev --[major]--> 2.0.0

1.0.0-dev --[minor]--> 1.0.0
1.0.1-dev --[minor]--> 1.1.0
1.1.0-dev --[minor]--> 1.1.0

1.0.0-dev --[patch]--> 1.0.0
1.0.1-dev --[patch]--> 1.0.1
1.1.0-dev --[patch]--> 1.1.0

What currently happens:

1.0.0-dev --[major]--> 2.0.0
1.0.1-dev --[major]--> 2.0.0
1.1.0-dev --[major]--> 2.0.0

1.0.0-dev --[minor]--> 1.1.0
1.0.1-dev --[minor]--> 1.1.0
1.1.0-dev --[minor]--> 1.2.0

1.0.0-dev --[patch]--> 1.0.1
1.0.1-dev --[patch]--> 1.0.2
1.1.0-dev --[patch]--> 1.1.1

If this a bug in the implementation, or have I missed something in the spec? Thanks!

@rbarrois

This comment has been minimized.

Copy link
Owner

commented Sep 15, 2015

Hi,

That's indeed a good suggestion.
Bumping is not documented in the SemVer spec though.

I'd like to merge your patch, however you have mixed in various changes.
Could you update your pull request to merge commits 37474ac and 6643a98 while removing the two following ones?

@MinchinWeb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2015

Okay, I split it into two pull requests. #27 just contains the version bumping code, #28 is just updating the copyright year in the copyright statements to include this year (2015). The hashes of the the commits have changed, but otherwise it's the same code.

@rbarrois rbarrois closed this in #27 Feb 11, 2016

@rbarrois

This comment has been minimized.

Copy link
Owner

commented Feb 11, 2016

@MinchinWeb Thanks! I've finally merged this :)

@MinchinWeb

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.