Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support npm/composer extensions? #30

Closed
skwashd opened this issue Oct 14, 2015 · 6 comments

Comments

@skwashd
Copy link
Contributor

commented Oct 14, 2015

npm and composer support the use of tilde (~) and caret (^) in version requirements. Would you accept a well written and tested patch that implements support for this in comparisons?

@rbarrois

This comment has been minimized.

Copy link
Owner

commented Oct 15, 2015

Hi,

This looks like an interesting feature indeed!

Just a note though: could you point me to a description of exactly what these extensions handle?
This will ease up the review :)

Thanks!

@skwashd

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2015

@rbarrois

This comment has been minimized.

Copy link
Owner

commented Oct 20, 2015

@skwashd Thanks for all.

I'm trying to bring back some life into my various open-source projects, so this PR might have to wait a couple more days before I get some time to look into it, sorry :/

And please ping me if you haven't received any answer by next week!!

@pfifi-puppet

This comment has been minimized.

Copy link

commented Oct 21, 2015

@rbarrois no rush. I have run into some issues when extending this to support the full extended syntax as supported by npm and composer.

When #31 and #32 are used together things break. I have time scheduled to work on this again on Friday.

@skwashd

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2015

@rbarrois I've updated #31 and #32.

@rbarrois

This comment has been minimized.

Copy link
Owner

commented Feb 12, 2016

@skwashd I've just merged and fixed this, thanks again for the suggestion!

@rbarrois rbarrois closed this Feb 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.