Skip to content

Loading…

build_package_standard does not correctly parse MAKEOPTS #149

Closed
sax opened this Issue · 1 comment

2 participants

@sax

In bin/ruby-build these lines attempt to parse out make options:

if [ -z "${MAKEOPTS+defined}" ]; then
  MAKE_OPTS="$MAKEOPTS"
elif [ -z "${MAKE_OPTS+defined}" ]; then
  MAKE_OPTS="-j 2"
fi

The logic is incorrect

  • if MAKEOPTS is not defined, set MAKE_OPTS to MAKEOPTS
  • else if MAKEOPTS is not defined, set MAKE_OPTS

The only way to actually set MAKE_OPTS is to define both MAKEOPTS and MAKE_OPTS.

@jeremy

Nice catch! Could you submit a pull request with the fix?

@jeremy jeremy closed this in 698a72d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.