Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should after_install hooks execute even when installation has failed? #331

Closed
mislav opened this issue Mar 21, 2013 · 2 comments
Closed

Should after_install hooks execute even when installation has failed? #331

mislav opened this issue Mar 21, 2013 · 2 comments

Comments

@mislav
Copy link
Member

mislav commented Mar 21, 2013

Currently, after_install hooks always run, even if installation failed. Plugin authors are expected to check $STATUS, as far as I'm guessing. They might not be aware of that.

Could after_install simply be skipped if installation failed?
mislav added a commit to mislav/rbenv-ctags that referenced this issue Mar 21, 2013
@mislav
check STATUS to see if installation failed
caa6a06 
References rbenv/ruby-build#331
@mislav mislav mentioned this issue Mar 21, 2013
Merged
@sstephenson
Copy link
Contributor

Yeah, checking $STATUS is part of the contract. I definitely think hooks should be given a chance to clean up after a failed installation.

@mislav
Copy link
Member Author

mislav commented Mar 21, 2013

Fair enough

@mislav mislav closed this as completed Mar 21, 2013
@keith keith mentioned this issue Apr 9, 2013
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mislav @sstephenson