Add TruffleRuby to ruby-build #1210

Merged
merged 5 commits into from Jun 15, 2018

Conversation

Projects
None yet
2 participants
@eregon
Contributor

eregon commented Jun 15, 2018

Hello,

Here is a PR to add TruffleRuby to ruby-build.
I tried to keep the logic as simple as possible, and to update all relevant places mentioning other implementations.

I tested it locally and it seems to work well.
I also added a couple tests for the new logic.

This is a fully open-source version of TruffleRuby, corresponding to a subset of the Community Edition of GraalVM (See http://www.graalvm.org/downloads/)
It includes the native configuration only, not the JVM configuration, so there is no JVM involved.

@eregon

This comment has been minimized.

Show comment
Hide comment
@eregon

eregon Jun 15, 2018

Contributor

I'm sure why the CI failed. It looks like it tried to download the truffleruby archive and check the checksum, but took more than 10 minutes to download the 40MB archive.
Maybe it should just be restarted as the network might be unreliably slow?

Contributor

eregon commented Jun 15, 2018

I'm sure why the CI failed. It looks like it tried to download the truffleruby archive and check the checksum, but took more than 10 minutes to download the 40MB archive.
Maybe it should just be restarted as the network might be unreliably slow?

@eregon

This comment has been minimized.

Show comment
Hide comment
@eregon

eregon Jun 15, 2018

Contributor

Running locally with:

$ TRAVIS_COMMIT_RANGE=master... TRAVIS_PULL_REQUEST=true PATH="./bats/bin:$PATH" script/test

gives

...
101 tests, 0 failures
Verifying checksum for https://github.com/oracle/truffleruby/releases/download/vm-1.0.0-rc2/truffleruby-1.0.0-rc2-linux-amd64.tar.gz
Verifying checksum for https://github.com/oracle/truffleruby/releases/download/vm-1.0.0-rc2/truffleruby-1.0.0-rc2-macos-amd64.tar.gz
Verifying checksum for https://www.openssl.org/source/openssl-1.1.0h.tar.gz
23.32s user 16.53s system 17% cpu 3:48.50 total
Contributor

eregon commented Jun 15, 2018

Running locally with:

$ TRAVIS_COMMIT_RANGE=master... TRAVIS_PULL_REQUEST=true PATH="./bats/bin:$PATH" script/test

gives

...
101 tests, 0 failures
Verifying checksum for https://github.com/oracle/truffleruby/releases/download/vm-1.0.0-rc2/truffleruby-1.0.0-rc2-linux-amd64.tar.gz
Verifying checksum for https://github.com/oracle/truffleruby/releases/download/vm-1.0.0-rc2/truffleruby-1.0.0-rc2-macos-amd64.tar.gz
Verifying checksum for https://www.openssl.org/source/openssl-1.1.0h.tar.gz
23.32s user 16.53s system 17% cpu 3:48.50 total
@hsbt

This comment has been minimized.

Show comment
Hide comment
@hsbt

hsbt Jun 15, 2018

Contributor

@eregon Thanks! I'm happy to add TruffleRuby definition.

Contributor

hsbt commented Jun 15, 2018

@eregon Thanks! I'm happy to add TruffleRuby definition.

@hsbt hsbt merged commit e73041e into rbenv:master Jun 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eregon

This comment has been minimized.

Show comment
Hide comment
@eregon

eregon Jun 16, 2018

Contributor

@hsbt Thank you for merging!

Is there a release of ruby-build planned soon?
It would be great so more people can easily try TruffleRuby, especially for Homebrew users.
(Users of ruby-build as a plugin can just git pull so that's already good 😃 )

Contributor

eregon commented Jun 16, 2018

@hsbt Thank you for merging!

Is there a release of ruby-build planned soon?
It would be great so more people can easily try TruffleRuby, especially for Homebrew users.
(Users of ruby-build as a plugin can just git pull so that's already good 😃 )

@eregon eregon referenced this pull request in oracle/truffleruby Jun 17, 2018

Closed

Support installing with ruby-build, ruby-install, RVM #1062

@hsbt

This comment has been minimized.

Show comment
Hide comment
@hsbt

hsbt Jun 18, 2018

Contributor

@eregon I did submit pull-request to homebrew-core. Homebrew/homebrew-core#29151

Contributor

hsbt commented Jun 18, 2018

@eregon I did submit pull-request to homebrew-core. Homebrew/homebrew-core#29151

@eregon

This comment has been minimized.

Show comment
Hide comment
@eregon

eregon Jun 18, 2018

Contributor

@hsbt Awesome, thank you!

Contributor

eregon commented Jun 18, 2018

@hsbt Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment