Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TruffleRuby to ruby-build #1210

Merged
merged 5 commits into from Jun 15, 2018
Merged

Add TruffleRuby to ruby-build #1210

merged 5 commits into from Jun 15, 2018

Conversation

eregon
Copy link
Member

@eregon eregon commented Jun 15, 2018

Hello,

Here is a PR to add TruffleRuby to ruby-build.
I tried to keep the logic as simple as possible, and to update all relevant places mentioning other implementations.

I tested it locally and it seems to work well.
I also added a couple tests for the new logic.

This is a fully open-source version of TruffleRuby, corresponding to a subset of the Community Edition of GraalVM (See http://www.graalvm.org/downloads/)
It includes the native configuration only, not the JVM configuration, so there is no JVM involved.

@eregon
Copy link
Member Author

eregon commented Jun 15, 2018

I'm sure why the CI failed. It looks like it tried to download the truffleruby archive and check the checksum, but took more than 10 minutes to download the 40MB archive.
Maybe it should just be restarted as the network might be unreliably slow?

@eregon
Copy link
Member Author

eregon commented Jun 15, 2018

Running locally with:

$ TRAVIS_COMMIT_RANGE=master... TRAVIS_PULL_REQUEST=true PATH="./bats/bin:$PATH" script/test

gives

...
101 tests, 0 failures
Verifying checksum for https://github.com/oracle/truffleruby/releases/download/vm-1.0.0-rc2/truffleruby-1.0.0-rc2-linux-amd64.tar.gz
Verifying checksum for https://github.com/oracle/truffleruby/releases/download/vm-1.0.0-rc2/truffleruby-1.0.0-rc2-macos-amd64.tar.gz
Verifying checksum for https://www.openssl.org/source/openssl-1.1.0h.tar.gz
23.32s user 16.53s system 17% cpu 3:48.50 total

@hsbt
Copy link
Member

hsbt commented Jun 15, 2018

@eregon Thanks! I'm happy to add TruffleRuby definition.

@hsbt hsbt merged commit e73041e into rbenv:master Jun 15, 2018
1 check passed
@eregon
Copy link
Member Author

eregon commented Jun 16, 2018

@hsbt Thank you for merging!

Is there a release of ruby-build planned soon?
It would be great so more people can easily try TruffleRuby, especially for Homebrew users.
(Users of ruby-build as a plugin can just git pull so that's already good 😃 )

@hsbt
Copy link
Member

hsbt commented Jun 18, 2018

@eregon I did submit pull-request to homebrew-core. Homebrew/homebrew-core#29151

@eregon
Copy link
Member Author

eregon commented Jun 18, 2018

@hsbt Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants