Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t look for Homebrew openssl #1375

Merged
merged 2 commits into from Nov 11, 2019
Merged

Don’t look for Homebrew openssl #1375

merged 2 commits into from Nov 11, 2019

Conversation

@gfguthrie
Copy link
Contributor

gfguthrie commented Nov 8, 2019

ruby-build already does a lot of work to make sure that the version of ruby you're installing has the correct version of openssl also installed. Looking for any version of openssl installed by Homebrew is problematic for a few reasons:

  • The user may have an incompatible version installed
  • The user may not know that a particular version of openssl has been installed by Homebrew
  • The openssl version split now makes this logic more difficult to maintain for all versions of ruby that ruby-build can install

Let's stop looking for any version of Homebrew's openssl by default so that the user always gets a working version of the ruby they're installing. Advanced users can use the RUBY_CONFIGURE_OPTS="--with-openssl-dir=/my-openssl-directory" option if they don't want to install the ruby-build defined compatible version of openssl.

#1353 #1360 #1347

Copy link
Member

mislav left a comment

Interesting idea, thanks for proposing!

bin/ruby-build Show resolved Hide resolved
@gfguthrie gfguthrie requested a review from mislav Nov 8, 2019
@mislav
mislav approved these changes Nov 10, 2019
@mislav mislav requested review from hsbt and jasonkarns Nov 10, 2019
@mislav mislav merged commit a0dcf52 into rbenv:master Nov 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gfguthrie gfguthrie mentioned this pull request Nov 11, 2019
5 of 5 tasks complete
@hsbt

This comment has been minimized.

Copy link
Member

hsbt commented Nov 13, 2019

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.