From bb2b110dd14cbe1f66cae17ac3560ac507145b81 Mon Sep 17 00:00:00 2001 From: ohbarye Date: Mon, 20 Feb 2023 22:23:26 +0900 Subject: [PATCH 1/2] Remove brew update instruction because `brew update` runs automatically on `brew upgrade` by default since long time ago. --- README.md | 4 ++-- bin/rbenv-install | 2 +- test/rbenv.bats | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index a813179e83..681f6dd0b5 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ brew install ruby-build Upgrade with: ```sh -brew update && brew upgrade ruby-build +brew upgrade ruby-build ``` ### Clone as rbenv plugin using git @@ -48,7 +48,7 @@ $ ruby-build --definitions # lists all available versions of Ruby $ ruby-build 2.2.0 ~/local/ruby-2.2.0 # installs Ruby 2.2.0 to ~/local/ruby-2.2.0 ``` -> **Warning** +> **Warning** > ruby-build mostly does not verify that system dependencies are present before downloading and attempting to compile Ruby from source. Please ensure that [all requisite libraries][build-env] such as build tools and development headers are already present on your system. Basically, what ruby-build does when installing a Ruby version is this: diff --git a/bin/rbenv-install b/bin/rbenv-install index 569e4895f3..4f6a3e5aad 100755 --- a/bin/rbenv-install +++ b/bin/rbenv-install @@ -240,7 +240,7 @@ if [ "$STATUS" == "2" ]; then echo -n "If the version you need is missing, try upgrading ruby-build" if [ "$here" != "${here#$(brew --prefix 2>/dev/null)}" ]; then printf ":\n\n" - echo " brew update && brew upgrade ruby-build" + echo " brew upgrade ruby-build" elif [ -d "${here}/.git" ]; then printf ":\n\n" echo " git -C ${here} pull" diff --git a/test/rbenv.bats b/test/rbenv.bats index 4293fe4f5f..9907825f90 100644 --- a/test/rbenv.bats +++ b/test/rbenv.bats @@ -114,7 +114,7 @@ See all available versions with \`rbenv install --list'. If the version you need is missing, try upgrading ruby-build: - brew update && brew upgrade ruby-build + brew upgrade ruby-build OUT unstub brew From ad71af30d0ab8b61d7a13da28af42873de497674 Mon Sep 17 00:00:00 2001 From: Masato Ohba Date: Mon, 20 Feb 2023 23:50:09 +0900 Subject: [PATCH 2/2] Retrieve meaningful whitespace --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 681f6dd0b5..91ff27014e 100644 --- a/README.md +++ b/README.md @@ -48,7 +48,7 @@ $ ruby-build --definitions # lists all available versions of Ruby $ ruby-build 2.2.0 ~/local/ruby-2.2.0 # installs Ruby 2.2.0 to ~/local/ruby-2.2.0 ``` -> **Warning** +> **Warning** > ruby-build mostly does not verify that system dependencies are present before downloading and attempting to compile Ruby from source. Please ensure that [all requisite libraries][build-env] such as build tools and development headers are already present on your system. Basically, what ruby-build does when installing a Ruby version is this: