Use comptime to provide NIF wrappers
#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if a passed type is a resource created with the Resource generic function
Make it more clear than the type refers to the type of a single item
Allow wrapping an (almost) arbitrary function with a NIF wrapper that exposes the interface that the Erlang runtime expects. This allows to remove some boilerplate and makes the function interfaces clearer. Have I already mentioned how much I love comptime?
Remove some more boilerplate by moving setter generation in batch.zig and making it generic over the item type.
Also generate submit_fn generic over operation using comptime
rbino
force-pushed
the
refactoring/nif-wrapper
branch
from
2867276 to
85acb28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce some of the mechanical noise of argument conversion and make parameter types more evident