Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display (SG and Audio, show_batch) #15

Open
jdiedrick opened this issue Jan 22, 2020 · 2 comments
Open

Fix display (SG and Audio, show_batch) #15

jdiedrick opened this issue Jan 22, 2020 · 2 comments
Labels
bug

Comments

@jdiedrick
Copy link

@jdiedrick jdiedrick commented Jan 22, 2020

Fix the AudioSpectrogram and AudioItem display to be proper and compatible with how fastai handles display.

It is tricky because we aim to support multichannel audio, and multiple images per channel (e.g. MFCC + it's delta/accelerate for each audio channel). This means a single stereo audio clip that has MFCC + delta/accelerate will be 6 images, this creates a problem for stuff like show_batch and I don't know how to resolve.

We also want to have a grid + colorbar which I've had difficulty with for multiplot display.

I propose someone more familiar with matplotlib and fastai display rewrite it to be fully functional

I'd also like to add a parameter to AudioSpectrogram's to show a audio player beneath them. It might not be too hard and will be useful to hear your spectrograms! After awhile it you can get lost as to what you are looking at sounds like :)

This should also work properly as expected for show_batch() for training purposes

@scart97 scart97 added the bug label Feb 20, 2020
@jdiedrick

This comment has been minimized.

Copy link
Author

@jdiedrick jdiedrick commented Mar 9, 2020

@rbracco @scart97 Looking into this now. I'm in the 02_tutorial.ipynb file, and if I uncomment this line:

dbunch_cropspec.show_batch(max_n=9)

and change it to:

'dbunch.show_batch(max_n=9)'

its showing batches.

Does this mean that everything is ok? What is the expected/ideal behavior? If there is anymore information you can provide, I can keep working on this! Let me know.

@jdiedrick

This comment has been minimized.

Copy link
Author

@jdiedrick jdiedrick commented Mar 9, 2020

Here is the branch where I'll be working on this: https://github.com/aquietlife/fastai2_audio/tree/fix_display

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.