Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ruby 2.5.4, 2.5.5, 2.6.0, 2.6.1, 2.6.2, 2.6.3 #210

Merged
merged 4 commits into from May 19, 2019

Conversation

Projects
None yet
3 participants
@neosilky
Copy link
Collaborator

commented May 17, 2019

This fixes #207 and #159.

Note: line numbers do not work correctly in 2.6.x. Several things changed in the internals and I can't figure out why my code doesn't work. Still, they're only a guide and the flamegraphs seem to be generated correctly otherwise so I figured it's probably better to get this pushed so people can use it.

@jvns

This comment has been minimized.

Copy link
Collaborator

commented May 19, 2019

Thanks so much for this! I added an issue about the line numbers in 2.6.x.

@jvns jvns merged commit 03afd95 into rbspy:master May 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@neosilky neosilky deleted the neosilky:ruby-support branch May 19, 2019

@kirs

This comment has been minimized.

Copy link

commented Jun 4, 2019

@neosilky do we need a new rbspy release to include this PR? The latest release seems to be from February: https://github.com/rbspy/rbspy/releases

@neosilky

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 4, 2019

@kirs Yes. For the moment you can build rbspy using Rust.

@jvns Would you be able to release a new version?

@jvns

This comment has been minimized.

Copy link
Collaborator

commented Jun 8, 2019

@neosilky the steps to release a new version are:

  1. update Cargo.toml with the new version number & push a commit
  2. add a git tag with the new version number & push the tags

the CI will automatically build a binary and add it to the github releases page

@neosilky

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 8, 2019

@jvns Great, thanks!

@neosilky

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

@kirs Check 0.3.6, just released :)

@kirs

This comment has been minimized.

Copy link

commented Jun 14, 2019

❤️ 💚 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.