Permalink
Browse files

Don't add ordinals to the def files

If ordinals are added, linking to the created .lib file links
by ordinal instead of by name. Linking by name is preferred in
general (unless one wants to squeeze down the binary size). Linking
by ordinal only makes sense if the def file is maintained manually,
making sure the ordinal number of each function stays the same in
every build even if functions are added/removed.
  • Loading branch information...
mstorsjo committed Nov 17, 2012
1 parent 247326d commit b4ced8465158f68c8f5b252fe70e394a8545e91d
Showing with 1 addition and 3 deletions.
  1. +1 −3 makedef
View
@@ -145,7 +145,6 @@ foreach(@dump) {
close($file);
my $i = 1;
my $last = "none";
@syms = sort(@syms);
@@ -154,7 +153,6 @@ foreach my $sym (@syms) {
# Ignore any duplicate entries
next if ($last eq $sym);
print(" $sym \@$i\n");
print(" $sym\n");
$last = $sym;
$i++;
}

0 comments on commit b4ced84

Please sign in to comment.