Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added two images to part 03 #138

Merged
merged 3 commits into from Oct 5, 2023
Merged

Added two images to part 03 #138

merged 3 commits into from Oct 5, 2023

Conversation

AlexVCS
Copy link
Contributor

@AlexVCS AlexVCS commented Oct 5, 2023

working on #127

rcallaby
rcallaby requested changes Oct 5, 2023
View reviewed changes
Copy link
Owner

@rcallaby rcallaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I appreciate the contribution this doesn't fit the requirements of this issue. You supplied me with screenshots, not illustrative images of branching and merging. I was looking for something that illustrated graphically branching and merging.

For instance, the images used here:
https://gauravjanjal16.hashnode.dev/git-branching-and-merging

Illustrate Branching and Merging.

@AlexVCS
Copy link
Contributor Author

AlexVCS commented Oct 5, 2023

While I appreciate the contribution this doesn't fit the requirements of this issue. You supplied me with screenshots, not illustrative images of branching and merging. I was looking for something that illustrated graphically branching and merging.

For instance, the images used here: https://gauravjanjal16.hashnode.dev/git-branching-and-merging

Illustrate Branching and Merging.

Ok thanks, I wasn't quite sure what to go for, I'll change it.

@rcallaby rcallaby assigned AlexVCS and unassigned AlexVCS Oct 5, 2023
@AlexVCS
Copy link
Contributor Author

AlexVCS commented Oct 5, 2023

Please let me know what you think of this

rcallaby
rcallaby approved these changes Oct 5, 2023
View reviewed changes
Copy link
Owner

@rcallaby rcallaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for your contribution.

@rcallaby rcallaby merged commit 29a35ec into rcallaby:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcallaby rcallaby rcallaby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexVCS @rcallaby