Don't check can_open_socket() if the caller provides their own socket.

rcaputo · Feb 4, 2021 · 0dd7d80 · 0dd7d80
1 parent 7b6b7e2
commit 0dd7d80
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/POE/Component/Client/Ping.pm b/lib/POE/Component/Client/Ping.pm
@@ -83,7 +83,10 @@ sub spawn {
   croak "$type requires an even number of parameters" if @_ % 2;
   my %params = @_;
 
-  croak "$type requires root privilege" unless can_open_socket();
+  my $socket        = delete $params{Socket};
+  croak "$type requires root privilege" unless (
+    defined $socket or can_open_socket()
+  );
 
   my $alias         = delete $params{Alias};
   $alias            = "pinger" unless defined $alias and length $alias;
@@ -92,7 +95,6 @@ sub spawn {
   $timeout          = 1 unless defined $timeout and $timeout >= 0;
 
   my $onereply      = delete $params{OneReply};
-  my $socket        = delete $params{Socket};
   my $parallelism   = delete $params{Parallelism} || -1;
   my $rcvbuf        = delete $params{BufferSize};
   my $always_decode = delete $params{AlwaysDecodeAddress};